10844 Serialize ZTHR operations to eliminate races

Review Request #1790 — Created April 25, 2019 and submitted

jjelinek
illumos-gate
general

This is a port from ZoL for commit 61c3391acc9 Serialize ZTHR operations to eliminate races

zfs-test run

igork
  1. Ship It!
  2. 
      
kkantor
  1. I just had a couple clarifying questions about the cv_wait -> cv_wait_sig change. Otherwise this looks good!

  2. usr/src/uts/common/fs/zfs/zthr.c (Diff revision 1)
     
     

    In the SPL cv_wait_sig returns void, which isn't the case on illumos. In the SPL the _sig identifier just means that the wait can be interrupted by a signal, IIUC. Is that also the case on illumos (that cv_wait can't be interrupted by a signal but cv_wait_sig can? The man page isn't clear.)?

    It seems like we could preface this with (void) - does a linter check for this?

  3. 
      
jjelinek
kkantor
  1. Ship It!
  2. 
      
jjelinek
Review request changed

Status: Closed (submitted)

Loading...