Jerry Jelinek got a fish trophy!

10809 Performance optimization of AVL tree comparator functions

Review Request #1771 - Created April 18, 2019 and submitted

Information
Jerry Jelinek
illumos-gate
Reviewers
general

This is a port from ZoL of
ee36c709c3d Performance optimization of AVL tree comparator functions

I copied the performance results from the ZoL commit message into the bug report.

zfs-test run

Issues

  • 4
  • 0
  • 3
  • 7
Description From Last Updated
We should not just call into __builtin_expect everywhere. This should be rigged up in sys/ccompile.h as a macro like other ... Robert Mustacchi Robert Mustacchi
Should these be documented as part of libavl(3AVL) and avl(9F)? Robert Mustacchi Robert Mustacchi
I think we should probably consider keeping these as undocumented for the time being. Robert Mustacchi Robert Mustacchi
Rather than avl, should we use zfs here and in the userland header? Robert Mustacchi Robert Mustacchi
Toomas Soome
Igor Kozhukhov
Robert Mustacchi
Robert Mustacchi
Jerry Jelinek
Robert Mustacchi
Jerry Jelinek
Review request changed

Status: Closed (submitted)

Loading...