10782 blowfish: NULL pointer errors

Review Request #1747 — Created April 14, 2019 and submitted

tsoome
illumos-gate
10782
88f06b1...
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/systm.h:39,
                 from ../../common/crypto/io/blowfish.c:31:
../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/crypto/io/blowfish.c:197:60: note: in expansion of macro 'NULL'
 static crypto_kcf_provider_handle_t blowfish_prov_handle = NULL;
                                                            ^~~~
../../common/crypto/io/blowfish.c: In function '_fini':
../../common/crypto/io/blowfish.c:221:27: error: comparison between pointer and integer [-Werror]
  if (blowfish_prov_handle != NULL) {
                           ^~
../../common/crypto/io/blowfish.c:225:24: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   blowfish_prov_handle = NULL;
                        ^
cc1: all warnings being treated as errors


andy_js
  1. Ship It!
  2. 
      
wiedi
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...