10772 kcf: NULL pointer errors

Review Request #1737 - Created April 14, 2019 and submitted

Information
Toomas Soome
illumos-gate
10772
64bae09...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/systm.h:39,
                 from ../../common/crypto/core/kcf_cryptoadm.c:31:
../../common/crypto/core/kcf_cryptoadm.c: In function 'kcf_soft_config_init':
../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/crypto/core/kcf_cryptoadm.c:162:16: note: in expansion of macro 'NULL'
      "random", NULL};
                ^~~~
../../common/sys/null.h:32:14: note: (near initialization for 'swrand_mechs[1][0]')
 #define NULL ((void *)0)
              ^
../../common/crypto/core/kcf_cryptoadm.c:162:16: note: in expansion of macro 'NULL'
      "random", NULL};
                ^~~~

In file included from ../../common/sys/crypto/sched_impl.h:48:0,
                 from ../../common/crypto/api/kcf_dual.c:33:
../../common/crypto/api/kcf_dual.c: In function 'crypto_encrypt_mac':
../../common/sys/crypto/ops_impl.h:392:15: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  mops->mo_sid = _sid;      \
               ^
../../common/crypto/api/kcf_dual.c:263:5: note: in expansion of macro 'KCF_WRAP_MAC_OPS_PARAMS'
     KCF_WRAP_MAC_OPS_PARAMS(&(next_req->kr_params),
     ^~~~~~~~~~~~~~~~~~~~~~~
../../common/crypto/api/kcf_dual.c: In function 'crypto_mac_decrypt_common':
../../common/sys/crypto/ops_impl.h:428:16: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  cops->dop_sid = _sid;      \
                ^
../../common/crypto/api/kcf_dual.c:1214:5: note: in expansion of macro 'KCF_WRAP_DECRYPT_OPS_PARAMS'
     KCF_WRAP_DECRYPT_OPS_PARAMS(
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Andrew Stormont
Robert Mustacchi
Toomas Soome
Robert Mustacchi
Toomas Soome
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...