10752 fcsm: NULL pointer errors

Review Request #1718 - Created April 12, 2019 and updated

Information
Toomas Soome
illumos-gate
10752
5bb7c7c...
Reviewers
general
In file included from /code/illumos-gate/proto/root_i386/usr/include/sys/param.h:48:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/t_lock.h:38,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/file.h:35,
                 from ../../common/io/fibre-channel/ulp/fcsm.c:31:
../../common/io/fibre-channel/ulp/fcsm.c: In function 'fcsm_attach':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:32:14: error: passing argument 4 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/fibre-channel/ulp/fcsm.c:433:7: note: in expansion of macro 'NULL'
       NULL, DDI_PSEUDO, 0) == DDI_SUCCESS) {
       ^~~~
In file included from /code/illumos-gate/proto/root_i386/usr/include/sys/scsi/scsi_types.h:61:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/scsi/scsi.h:36,
                 from ../../common/io/fibre-channel/ulp/fcsm.c:33:
/code/illumos-gate/proto/root_i386/usr/include/sys/sunddi.h:1564:1: note: expected 'minor_t {aka unsigned int}' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
Sebastian Wiedenroth
Ship It!
Robert Mustacchi
Ship It!
Loading...