6723 etc/skel needs cleanup
Review Request #170 — Created March 4, 2016 and submitted
Information | |
---|---|
tsoome | |
illumos-gate | |
2931, 6723 | |
Reviewers | |
general | |
etc/skel cleanup
tsoome@test:~$ more .bashrc
Define default prompt to <username>@<hostname>:<path><"($|#) ">
and print '#' for user "root" and '$' for normal users.
typeset +x PS1="\u@\h:\w\$ "
tsoome@test:~$
tsoome@test:~$ sudo -s
root@test:/home/tsoome# cd
root@test:~# pwd
/root
root@test:~# bash --version
GNU bash, version 4.3.42(1)-release (i386-pc-solaris2.11)
Change Summary:
Apparently the sh, jsh, ksh, ksh93 already have the same prompt as default, so only need PS1 for bash.
Diff: |
Revision 2 (+8 -94) |
---|
Change Summary:
set PATH in /etc/default/login, bash prompt in /etc/profile and .bashrc; leave only samples in .profile. note the sh/jsh/ksh shells get prompt from /etc/ksh.kshrc, except zsh, which is using its own set of init files.
Diff: |
Revision 3 (+32 -108) |
---|
Change Summary:
linked with issue number
Summary: |
|
||||
---|---|---|---|---|---|
Bugs: |
|
-
-
usr/src/cmd/login/login.dfl (Diff revision 3) is it intentional that order of /sbin and /usr/sbin is inverted vs. PATH above?
-
usr/src/cmd/nsadmin/etc-profile.sh (Diff revision 3) Do I miss something, or are double-semicolons ';;' no longer required in the end of case-clauses?
Change Summary:
switched /usr/sbin and /sbin in SUPATH to remain consistent with PATH
Diff: |
Revision 4 (+32 -108) |
---|
-
-
usr/src/cmd/nsadmin/dot-kshrc.sh (Diff revision 5) I don't think this file should be shipped at all if all it contains is aliases some people will like and others won't.
-
usr/src/cmd/nsadmin/etc-profile.sh (Diff revision 5) While case statement fall-through works for bash and ksh93, it is not specified by POSIX and this is invalid syntax in eg. dash.
Change Summary:
moved bash PS1 setup to separate case statement to avoid the ;& construct, only deliver commented out samples in .kshrc
Diff: |
Revision 6 (+51 -109) |
---|
-
The PS1 simplificaitons are nice, but Why are you introducing "typeset ..." into the variable assignments?
-
My only comment is: this change turns what used to be gnu-first $PATH to a gnu-last $PATH. Personally, this doesn't affect me given my local user env forces what I like anyway but it is a change in behavior. (IOW, this isn't just a cleanup change.)
Change Summary:
do not deliver etc/skel/.bashrc as we do not deliver bash and this file is provided by distro's bash package.
Diff: |
Revision 9 (+52 -110) |
---|