10729 dev: NULL pointer errors

Review Request #1695 - Created April 11, 2019 and submitted

Information
Toomas Soome
illumos-gate
10729
5477c31...
Reviewers
general
../../common/fs/dev/sdev_ptsops.c: In function 'devpts_prunedir':
../../common/fs/dev/sdev_ptsops.c:231:41: error: comparison between pointer and integer [-Werror]
  if (rw_tryupgrade(&ddv->sdev_contents) == NULL) {
                                         ^~
../../common/fs/dev/sdev_netops.c: In function 'devnet_filldir':
../../common/fs/dev/sdev_netops.c:254:41: error: comparison between pointer and integer [-Werror]
  if (rw_tryupgrade(&ddv->sdev_contents) == NULL) {
                                         ^~

../../common/fs/dev/sdev_ipnetops.c: In function 'devipnet_filldir':
../../common/fs/dev/sdev_ipnetops.c:161:41: error: comparison between pointer and integer [-Werror]
  if (rw_tryupgrade(&ddv->sdev_contents) == NULL) {
                                         ^~
../../common/fs/dev/sdev_vtops.c: In function 'devvt_cleandir':
../../common/fs/dev/sdev_vtops.c:367:42: error: comparison between pointer and integer [-Werror]
  if (rw_tryupgrade(&sdvp->sdev_contents) == NULL) {
                                          ^~
../../common/fs/dev/sdev_vtops.c:411:49: error: comparison between pointer and integer [-Werror]
   if ((strcmp(dv->sdev_name, DEVVT_ACTIVE_NAME) == NULL))
                                                 ^~
../../common/fs/dev/sdev_vtops.c:413:51: error: comparison between pointer and integer [-Werror]
   if ((strcmp(dv->sdev_name, DEVVT_CONSUSER_NAME) == NULL))
                                                   ^~

../../common/fs/dev/sdev_zvolops.c: In function 'devzvol_create_pool_dirs':
../../common/fs/dev/sdev_zvolops.c:465:18: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   devzvol_zclist = NULL;
                  ^

../../common/fs/dev/sdev_profile.c: In function 'copyin_nvlist':
../../common/fs/dev/sdev_profile.c:900:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
cc1: all warnings being treated as errors

  
Andrew Stormont
Robert Mustacchi
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...