10720 iser: NULL pointer errors

Review Request #1686 - Created April 10, 2019 and submitted

Information
Toomas Soome
illumos-gate
10720
1fcfbfe...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/map.h:35,
                 from ../../common/sys/ddi.h:37,
                 from ../../common/io/ib/clients/iser/iser_cm.c:28:
../../common/io/ib/clients/iser/iser_cm.c: In function 'iser_handle_cm_conn_est':
../../common/sys/null.h:32:14: error: passing argument 3 of 'idm_conn_event' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/ib/clients/iser/iser_cm.c:286:41: note: in expansion of macro 'NULL'
   idm_conn_event(ic, CE_CONNECT_ACCEPT, NULL);
                                         ^~~~
In file included from ../../common/sys/idm/idm.h:283:0,
                 from ../../common/sys/ib/clients/iser/iser.h:42,
                 from ../../common/io/ib/clients/iser/iser_cm.c:36:
../../common/sys/idm/idm_conn_sm.h:284:1: note: expected 'uintptr_t {aka long unsigned int}' but argument is of type 'void *'
 idm_conn_event(struct idm_conn_s *ic, idm_conn_event_t event, uintptr_t data);
 ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
John Levon
Robert Mustacchi
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...