10718 av1394: NULL pointer errors

Review Request #1684 - Created April 10, 2019 and submitted

Information
Toomas Soome
illumos-gate
10718
c525584...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/file.h:35,
                 from ../../common/io/1394/targets/av1394/av1394_async.c:35:
../../common/io/1394/targets/av1394/av1394_async.c: In function 'av1394_async_create_minor_node':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/1394/targets/av1394/av1394_async.c:447:23: note: in expansion of macro 'NULL'
      DDI_NT_AV_ASYNC, NULL);
                       ^~~~

In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/file.h:35,
                 from ../../common/io/1394/targets/av1394/av1394_isoch.c:30:
../../common/io/1394/targets/av1394/av1394_isoch.c: In function 'av1394_isoch_create_minor_node':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/1394/targets/av1394/av1394_isoch.c:321:23: note: in expansion of macro 'NULL'
      DDI_NT_AV_ISOCH, NULL);
                       ^~~~
In file included from ../../common/io/1394/targets/av1394/av1394_isoch.c:32:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
Sebastian Wiedenroth
Robert Mustacchi
Toomas Soome
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...