10708 pmcs: NULL pointer errors

Review Request #1674 — Created April 10, 2019 and submitted

tsoome
illumos-gate
10708
e75136f...
general
../../../../src/uts/common/io/scsi/adapters/pmcs/pmcs_attach.c:770:28: error: comparison between pointer and integer [-Werror]
  if (pwp->flash_chunk_addr == NULL) {
                            ^~

../../../../src/uts/common/io/scsi/adapters/pmcs/pmcs_scsa.c: In function 'pmcs_scsa_wq_run_one':
../../../../src/uts/common/io/scsi/adapters/pmcs/pmcs_scsa.c:1643:18: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      sp->cmd_tag = NULL;
                  ^
../../../../src/uts/common/io/scsi/adapters/pmcs/pmcs_scsa.c:1658:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
     sp->cmd_tag = NULL;
                 ^
../../../../src/uts/common/io/scsi/adapters/pmcs/pmcs_scsa.c: In function 'pmcs_SAS_run':
../../../../src/uts/common/io/scsi/adapters/pmcs/pmcs_scsa.c:1909:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
     sp->cmd_tag = NULL;
                 ^
cc1: all warnings being treated as errors


  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
wiedi
  1. Ship It!
  2. 
      
domag02
  1. 
      
  2. Space followed-by tab (+ in the next 2 line).
  3. Space followed-by tab.
  4. Should be:

                local[0] = '\0';
    
  5. 
      
tsoome
wiedi
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...