6707 disable grub menu management in libbe (loader project)

Review Request #167 — Created March 1, 2016 and submitted

Information
tsoome
illumos-gate
6707
Reviewers
general 
6707 disable grub menu management in libbe (loader project)
add BE_HAS_GRUB=true to /etc/default/be to enable grub.
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
tsoome
yuripv
yuripv 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      usr/src/lib/libbe/common/be_utils.c
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    What about the be_is_isa("i386") check that you removed from be_has_grub()?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      right... it went left;)
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




tsoome




   

   

  

 



 















 



 

  

   




tsoome




   

   

  

 



 















 





 

  

   




richlowe




   

   







  

 



 

  


   

   

    
 
richlowe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      usr/src/lib/libbe/common/be_utils.c
      


       (Diff revision 4)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    "Cache the defaults, because be_has_grub is used often"
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




tsoome




   

   

  

 



 















 





 

  

   




richlowe




   

   







  

 



 

  


   

   

    
 
richlowe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




andy_js




   

   





  

 



 

  


   

   

    
 
andy_js


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Can't detection of GRUB be done programatically?  I'm sure I've seen this capability in one of the libraries.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      well, the trivial test has been in bootadm - if /boot/grub/stage1 exists, the grub is there. But, the purpose of this (and bootadm similar update) is not to test if the grub exists but to have way to enforce one or another boot loader as default.
      

      The current code, is setting loader as default, which by itself is good, but, there may be need to delay actual switch while keeping illumos-gate in sync. For example distro needing extra time to update deployment, helpdesk whatever... and once the time is right, make the actual switch.
      

      Detecting grub/loader by file check is actually quite meaningless also, as I do have both packages installed... And as the final point, flipping between different bootloaders will only end badly confused setup, so we really dont want to do that either.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




tsoome




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...