10699 loader: smatch cleanups for ficl

Review Request #1668 — Created April 7, 2019 and submitted

tsoome
illumos-gate
10699
1789
1c33b9e...
general
10699 loader: smatch cleanups for ficl


  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
jlevon
  1. 
      
  2. usr/src/common/ficl/loader.c (Diff revision 1)
     
     

    can we coalesce these two sections (:685-:721)? Right now with the removed return if somebody adds something at :721 it could be wrong.

  3. usr/src/common/ficl/primitives.c (Diff revision 1)
     
     

    as below

  4. usr/src/common/ficl/vm.c (Diff revision 1)
     
     

    I'm not a fan of these case statements lacking break; even if we know this is a NORETURN statement. Can we not have break; here at least?

    1. apparently smatch does not complain:)

  5. 
      
jlevon
  1. 
      
  2. 
      
tsoome
domag02
  1. 
      
  2. usr/src/common/ficl/loader.c (Diff revision 2)
     
     

    Though not in practice, but implicit down-conversion can happen when datamodel is LP64 (or maybe compiler/smatch warn to this).

    Solution: type of count variable should be ficlInteger.

    1. here in this case it does not really matter.

  3. 
      
tsoome
jlevon
  1. 
      
  2. usr/src/common/ficl/primitives.c (Diff revisions 1 - 3)
     
     

    Indenting still wrong here?

  3. 
      
tsoome
jlevon
  1. RB won't let me see the actual change (seems like there's no way to show whitespace changes, "helpfully"), but thanks.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...