usr/src/common/ficl/loader.c (Diff revision 1)

Show all issues

can we coalesce these two sections (:685-:721)? Right now with the removed return if somebody adds something at :721 it could be wrong.

1. 

   Toomas Soome April 7, 2019, 10:45 a.m.

   yes:)

usr/src/common/ficl/primitives.c (Diff revision 1)

Show all issues

as below

usr/src/common/ficl/vm.c (Diff revision 1)

Show all issues

I'm not a fan of these case statements lacking break; even if we know this is a NORETURN statement. Can we not have break; here at least?

1. 

   Toomas Soome April 7, 2019, 10:45 a.m.

   apparently smatch does not complain:)

usr/src/common/ficl/loader.c (Diff revision 2)

Show all issues

Though not in practice, but implicit down-conversion can happen when datamodel is LP64 (or maybe compiler/smatch warn to this).
Solution: type of count variable should be ficlInteger.

1. 

   Toomas Soome April 8, 2019, 7:07 a.m.

   here in this case it does not really matter.

usr/src/common/ficl/primitives.c (Diff revisions 1 - 3)

Show all issues

Indenting still wrong here?

RB won't let me see the actual change (seems like there's no way to show whitespace changes, "helpfully"), but thanks.