-
-
usr/src/common/ficl/loader.c (Diff revision 1) can we coalesce these two sections (:685-:721)? Right now with the removed return if somebody adds something at :721 it could be wrong.
-
-
usr/src/common/ficl/vm.c (Diff revision 1) I'm not a fan of these case statements lacking break; even if we know this is a NORETURN statement. Can we not have break; here at least?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+22 -20) |
-
-
usr/src/common/ficl/loader.c (Diff revision 2) Though not in practice, but implicit down-conversion can happen when datamodel is LP64 (or maybe compiler/smatch warn to this).
Solution: type of
count
variable should beficlInteger
.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+23 -21) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+27 -25) |