Fish Trophy

tsoome got a fish trophy!

10688 gfx_private needs smatch fixes

Review Request #1661 — Created April 5, 2019 and submitted

tsoome
illumos-gate
10688
31093ec...
general
10688 gfx_private needs smatch fixes


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
andy_js
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
rm
  1. 
      
  2. How did you pick EFAULT for these? It doesn't feel like the only operation that the setmode entry points could ever run is copying in and out memory from userland since we've taken away all the arguments here that could have come from userland.
    
    Since these all return an integer, any reason we shouldn't propagate that actual error?
    
    Note, this applies to all of the setmode() calls.
    1. The problem is that setmode() does return boolean. true or false and error codes are eaten. So I was in trouble - or still am. I am not sure what would be appropriate error code there.

    2. Maybe we should use EIO, as it's a generic something what wrong with the device request error code and at least would point someone to saying, hmm, maybe there's an issue between the driver and hardware, which is what would be the first place to look if we had a failure here.

  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...