10676 fbt: NULL pointer errors

Review Request #1649 — Created April 2, 2019 and submitted

tsoome
illumos-gate
10676
1f0c625...
general
../../intel/dtrace/fbt.c: In function 'fbt_invop':
../../intel/dtrace/fbt.c:120:28: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
     CPU->cpu_dtrace_caller = NULL;
                            ^
../../intel/dtrace/fbt.c:137:28: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
     CPU->cpu_dtrace_caller = NULL;
                            ^
../../intel/dtrace/fbt.c: In function 'fbt_provide_module':
../../intel/dtrace/fbt.c:186:55: error: comparison between pointer and integer [-Werror]
  if (str == NULL || symhdr == NULL || symhdr->sh_addr == NULL) {
                                                       ^~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/thread.h:36,
                 from ../../common/sys/modctl.h:35,
                 from ../../intel/dtrace/fbt.c:27:
../../intel/dtrace/fbt.c: In function 'fbt_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../intel/dtrace/fbt.c:724:18: note: in expansion of macro 'NULL'
      DDI_PSEUDO, NULL) == DDI_FAILURE ||
                  ^~~~
In file included from ../../intel/dtrace/fbt.c:32:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


andy_js
  1. Ship It!
  2. 
      
pmooney
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...