10675 sdt: NULL pointer issues

Review Request #1648 — Created April 2, 2019 and submitted

tsoome
illumos-gate
10675
1331002...
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/thread.h:36,
                 from ../../common/sys/modctl.h:35,
                 from ../../intel/dtrace/sdt.c:31:
../../intel/dtrace/sdt.c: In function 'sdt_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../intel/dtrace/sdt.c:409:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                     ^~~~
In file included from ../../intel/dtrace/sdt.c:32:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


wiedi
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
jlevon
  1. Ship It!
  2. 
      
pmooney
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...