- Download Diff

Summary:

6704 svc.startd: replace grub_get_boot_args with be_get_boot_args (loader project)

Review Request #164 — Created March 1, 2016 and submitted Sept. 23, 2016, 5:12 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	6704
Depends On:
Reviewers
Groups:	general
People:

Description

Testing Done

Issues

0
0
3
0
All Issues: 3

Description	From	Last Updated
There's nothing to clean up.	yuripv	March 25, 2016, 8:34 a.m.
Don't need the check.	yuripv	March 25, 2016, 8:34 a.m.
Why is this not conditioned on __i386 anymore, when your other stuff still is?	richlowe	July 25, 2016, 1:20 p.m.

usr/src/cmd/svc/startd/graph.c (Diff revision 1)
Show all issues
```
There's nothing to clean up.
```
usr/src/cmd/svc/startd/graph.c (Diff revision 1)
Show all issues
```
Don't need the check.
```

Change Summary:

updates suggested by Yuri.

Diff:

Revision 2 (+12 -18)

Show changes

	usr/src/cmd/svc/startd/Makefile
	usr/src/cmd/svc/startd/graph.c

Ship it!

```
Ship It!
```

usr/src/cmd/svc/startd/graph.c (Diff revision 2)

Show all issues

Why is this not conditioned on __i386 anymore, when your other stuff still is?

Diff:

Revision 3 (+12 -16)

Show changes

	usr/src/cmd/svc/startd/Makefile
	usr/src/cmd/svc/startd/graph.c

Ship it!

```
Ship It!
```

Change Summary:

replaced __i386 with __x86

Diff:

Revision 4 (+21 -25)

Show changes

	usr/src/cmd/svc/startd/Makefile
	usr/src/cmd/svc/startd/graph.c

Change Summary:

fix rebase conflicts with 7267

Diff:

Revision 5 (+20 -24)

Show changes

	usr/src/cmd/svc/startd/Makefile
	usr/src/cmd/svc/startd/graph.c

Change Summary:

trivial conflict resolution after backout: 7267 SMF is fast and loose with optional dependencies (needs work)

Diff:

Revision 6 (+20 -24)

Show changes

	usr/src/cmd/svc/startd/Makefile
	usr/src/cmd/svc/startd/graph.c

Change Summary:

fix cstyle issue about graph_walk_dependencies() arguments.

Diff:

Revision 7 (+22 -26)

Show changes

	usr/src/cmd/svc/startd/Makefile
	usr/src/cmd/svc/startd/graph.c

You have a pending review.

Review Board 3.0.18

6704 svc.startd: replace grub_get_boot_args with be_get_boot_args (loader project)

Change Summary:

Diff:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Status: Closed (submitted)