10657 ksslf: NULL pointer errors

Review Request #1630 — Created April 1, 2019 and submitted

tsoome
illumos-gate
10657
2d10c9f...
general
../../common/inet/kssl/ksslfilter.c: In function 'kssl_input_callback':
../../common/inet/kssl/ksslfilter.c:566:18: error: comparison between pointer and integer [-Werror]
      TQ_NOSLEEP) == NULL) {
                  ^~

../../common/inet/kssl/ksslapi.c: In function 'kssl_handle_mblk':
../../common/inet/kssl/ksslapi.c:557:12: error: incompatible types when returning type 'void *' but 'kssl_cmd_t {aka enum <anonymous>}' was expected
     return (NULL);
            ^

../../common/inet/kssl/ksslrec.c: In function 'kssl_free_context':
../../common/inet/kssl/ksslrec.c:2491:21: error: comparison between pointer and integer [-Werror]
   if (ssl->job.kjob != NULL) {
                     ^~
../../common/inet/kssl/ksslrec.c:2503:22: error: comparison between pointer and integer [-Werror]
    if (ssl->job.kjob != NULL) {
                      ^~
../../common/inet/kssl/ksslrec.c:2512:25: error: comparison between pointer and integer [-Werror]
  } while (ssl->job.kjob != NULL);
                         ^~
cc1: all warnings being treated as errors


  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
domag02
  1. 
      
  2. usr/src/uts/common/inet/kssl/ksslrec.c (Diff revision 1)
     
     

    Should be:

    kssl_ssl3_key_material_derive_step(ssl_t *ssl, uchar_t *secret,
        size_t secretlen, int step, uchar_t *dst, int sr_first)
    
  3. 
      
tsoome
rm
  1. 
      
  2. usr/src/uts/common/inet/kssl/ksslapi.c (Diff revision 2)
     
     
    Should we use the actual enum value that this is, mainly, KSSL_CMD_NOT_SUPPORTED?
  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...