-
-
usr/src/uts/common/io/sysevent.c (Diff revision 1) Could probably omit the name comments to the right if you're including the c99-style initializer names.
10648 sysevent: NULL pointer errors
Review Request #1622 — Created April 1, 2019 and submitted
Information | |
---|---|
tsoome | |
illumos-gate | |
10648 | |
8bdec29... | |
Reviewers | |
general | |
In file included from ../../common/sys/param.h:48:0, from ../../common/io/sysevent.c:31: ../../common/io/sysevent.c: In function 'sysevent_attach': ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion] #define NULL ((void *)0) ^ ../../common/io/sysevent.c:706:21: note: in expansion of macro 'NULL' 0, DDI_PSEUDO, NULL) == DDI_FAILURE) { ^~~~ In file included from ../../common/io/sysevent.c:37:0: ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *' ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type, ^~~~~~~~~~~~~~~~~~~~~ In file included from ../../common/sys/param.h:48:0, from ../../common/io/sysevent.c:31: ../../common/io/sysevent.c: At top level: ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion] #define NULL ((void *)0) ^ ../../common/io/sysevent.c:745:2: note: in expansion of macro 'NULL' NULL, /* aread */ ^~~~ ../../common/sys/null.h:32:14: note: (near initialization for 'sysevent_cb_ops.cb_rev') #define NULL ((void *)0) ^ ../../common/io/sysevent.c:745:2: note: in expansion of macro 'NULL' NULL, /* aread */ ^~~~ cc1: all warnings being treated as errors
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+20 -19) |