10589 wscons: slow console oputput will trigger keyboard autorepeat

Review Request #1580 — Created March 25, 2019 and submitted

tsoome
illumos-gate
10589
822cbd9...
general
10589 wscons: slow console oputput will trigger keyboard autorepeat


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
tsoome
citrus
  1. 
      
  2. usr/src/uts/common/io/wscons.c (Diff revision 3)
     
     

    dependant

  3. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
ptribble
  1. Doesn't compile on SPARC:
    
    /export/home/ptribble/Illumos/wscons-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/cw --primary gcc4,/opt/gcc/4.4.4/bin/gcc,gnu  -- -xchip=ultra -Wc,-xcode=abs32 -Wc,-Qiselect-regsym=0 -m64 -xO3   ../../sparc/ml/sparc.il -D_ASM_INLINES -Xa -xspace -W0,-Lt -errtags=yes -errwarn=%all -_gcc=-Wno-missing-braces -_gcc=-Wno-sign-compare -_gcc=-Wno-unknown-pragmas -_gcc=-Wno-unused-parameter -_gcc=-Wno-missing-field-initializers -_gcc=-Wno-unused -_gcc=-Wno-empty-body -_smatch=-p=illumos_kernel -_smatch=--disable=uninitialized,check_check_deref,unreachable -_smatch=-Wno-vla -_smatch=-Wno-one-bit-signed-bitfield -_smatch=-Wno-external-function-has-definition -_smatch=-Wno-old-style-definition -_smatch=-Wno-strict-prototypes -_smatch=--disable=sizeof  -_gcc=-Wno-uninitialized -g -_cc=-xdebugformat=stabs -_gcc=-gdwarf-2 -Wc,-Qiselect-T1 -xc99=%all -W0,-noglobal -xc99=%all -Wd,-xsafe=unboundsym -Wc,-Qassembler-ounrefsym=0 -_gcc=-massume-32bit-callers -_gcc=-fno-inline-small-functions  -_gcc=-fno-inline-functions-called-once  -_gcc=-fno-ipa-cp  -_gcc7=-fno-ipa-icf  -_gcc8=-fno-ipa-icf  -_gcc7=-fno-clone-functions  -_gcc8=-fno-clone-functions -W2,-xwrap_int -W0,-xglobalstatic -xregs=no%float -xstrconst   -v -D_KERNEL -D_SYSCALL32 -D_SYSCALL32_IMPL -D_ELF64  -D_DDI_STRICT -Dsun -D__sun -D__SVR4      -I../../sparc -I../../sparc/krtld -I../../sparc/v9 -I../../sun -Y I,../../common  -c -o obj64/wscons.o ../../common/io/wscons.c
    + /opt/gcc/4.4.4/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -mno-integer-ldd-std -D__sun -mtune=ultrasparc -fno-pic -mcmodel=medlow -m64 -fno-strict-aliasing -fno-unit-at-a-time -fno-optimize-sibling-calls -O2 -D_ASM_INLINES -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused -Wno-empty-body -Wno-uninitialized -g -gdwarf-2 -std=gnu99 -std=gnu99 -massume-32bit-callers -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -mno-fpu -D_KERNEL -ffreestanding -D_SYSCALL32 -D_SYSCALL32_IMPL -D_ELF64 -D_DDI_STRICT -Dsun -D__sun -D__SVR4 -I../../sparc -I../../sparc/krtld -I../../sparc/v9 -I../../sun -nostdinc -I../../common -c -o obj64/wscons.o ../../common/io/wscons.c -mcpu=v9
    cc1: warnings being treated as errors
    ../../common/io/wscons.c: In function 'wcuwsrv':
    ../../common/io/wscons.c:599: error: pointer targets in passing argument 1 of 'console_puts' differ in signedness [-Wpointer-sign]
    ../../common/sys/console.h:67: note: expected 'const char *' but argument is of type 'unsigned char *'
    ../../common/io/wscons.c:627: error: 'return' with no value, in function returning non-void
    ../../common/io/wscons.c:632: error: 'nbp' undeclared (first use in this function)
    ../../common/io/wscons.c:632: error: (Each undeclared identifier is reported only once
    ../../common/io/wscons.c:632: error: for each function it appears in.)
    ../../common/io/wscons.c:641: error: label at end of compound statement
    *** Error code 1
    dmake: Warning: Command failed for target `obj64/wscons.o'
  2. 
      
tsoome
ptribble
  1. Tha almost fixed the SPARC build:
    
    ../../common/io/wscons.c: In function 'wcuwsrv':
    ../../common/io/wscons.c:641: error: label at end of compound statement
  2. 
      
tsoome
ptribble
  1. I've built and booted a SPARC ISO with these changes, which appears to work correctly.

  2. 
      
tsoome
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...