10437 dca: NULL pointer errors

Review Request #1506 - Created Feb. 22, 2019 and submitted

Information
Toomas Soome
illumos-gate
10437
81171d6...
Reviewers
general
../../common/crypto/io/dca.c: In function 'dca_attach':
../../common/crypto/io/dca.c:667:32: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  WORKLIST(dca, MCR1)->dwl_prov = NULL;
                                ^
../../common/crypto/io/dca.c:668:32: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  WORKLIST(dca, MCR2)->dwl_prov = NULL;
                                ^
../../common/crypto/io/dca.c:859:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR1)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c:863:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR2)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c: In function 'dca_detach':
../../common/crypto/io/dca.c:928:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR1)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c:936:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR2)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c: In function 'dca_uninit':
../../common/crypto/io/dca.c:1246:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   wlp->dwl_prov = NULL;
                 ^
../../common/crypto/io/dca.c: In function 'dca_bindchains':
../../common/crypto/io/dca.c:1930:21: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   reqp->dr_in_paddr = NULL;
                     ^
../../common/crypto/io/dca.c:1963:22: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   reqp->dr_out_paddr = NULL;
                      ^
../../common/crypto/io/dca.c: In function 'dca_unbindchains':
../../common/crypto/io/dca.c:1981:45: error: comparison between pointer and integer [-Werror]
  if (reqp->dr_chain_in_head.dc_buffer_paddr != NULL) {
                                             ^~
../../common/crypto/io/dca.c:1991:46: error: comparison between pointer and integer [-Werror]
  if (reqp->dr_chain_out_head.dc_buffer_paddr != NULL) {
                                              ^~
cc1: all warnings being treated as errors

  
Aurélien Larcher
Andrew Stormont
Robert Mustacchi
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...