10434 dump: NULL pointer errors

Review Request #1503 - Created Feb. 22, 2019 and submitted

Information
Toomas Soome
illumos-gate
10434
ba403b9...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/dump.c:32:
../../common/io/dump.c: In function 'dump_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/dump.c:57:66: note: in expansion of macro 'NULL'
  if (ddi_create_minor_node(devi, "dump", S_IFCHR, 0, DDI_PSEUDO, NULL) ==
                                                                  ^~~~
In file included from ../../common/io/dump.c:48:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
Aurélien Larcher
Andrew Stormont
Gergő Mihály Doma
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...