10432 devinfo: NULL pointer errors

Review Request #1501 - Created Feb. 22, 2019 and submitted

Information
Toomas Soome
illumos-gate
10432
b0e5ac8...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/vnode.h:46,
                 from ../../common/sys/pathname.h:37,
                 from ../../common/io/devinfo.c:30:
../../common/io/devinfo.c: In function 'di_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/devinfo.c:464:35: note: in expansion of macro 'NULL'
       DI_FULL_PARENT, DDI_PSEUDO, NULL) == DDI_FAILURE ||
                                   ^~~~
In file included from ../../common/io/devinfo.c:40:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/vnode.h:46,
                 from ../../common/sys/pathname.h:37,
                 from ../../common/io/devinfo.c:30:
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/devinfo.c:466:39: note: in expansion of macro 'NULL'
       DI_READONLY_PARENT, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                                       ^~~~
In file included from ../../common/io/devinfo.c:40:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
../../common/io/devinfo.c: In function 'di_copynode':
../../common/io/devinfo.c:1820:24: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  me->user_private_data = NULL;
                        ^
../../common/io/devinfo.c: In function 'di_getmdata':
../../common/io/devinfo.c:2539:25: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   me->user_private_data = NULL;
                         ^
cc1: all warnings being treated as errors

  
Toomas Soome
Aurélien Larcher
Gergő Mihály Doma
Andrew Stormont
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...