10431 conskbd: NULL pointer errors

Review Request #1500 - Created Feb. 22, 2019 and submitted

Information
Toomas Soome
illumos-gate
10431
b76ac29...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/conskbd.c:58:
../../common/io/conskbd.c: In function 'conskbd_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/conskbd.c:458:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) ||
                     ^~~~
In file included from ../../common/io/conskbd.c:69:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
../../common/io/conskbd.c: In function 'conskbd_alloc_firm_event':
../../common/io/conskbd.c:1686:12: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   fe->pair = NULL;
            ^
cc1: all warnings being treated as errors

  
Aurélien Larcher
Gergő Mihály Doma
Andrew Stormont
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...