-
-
usr/src/uts/sun4/os/trap.c (Diff revision 1) i'm not sure it is correct, in some cases you should to check others definitions, but you are ignore it with 'break' will be more correct to add "FALLTHROUGH" or try to find correct word from tsoome updates
10413 SPARC needs some gcc7 fixes
Review Request #1483 — Created Feb. 17, 2019 and updated
Information | |
---|---|
ptribble | |
illumos-gate | |
10413 | |
Reviewers | |
general | |
See ticket for details.
The one fix I'm unsure of is the sizeof() in prmachdep.c
I've done a gcc4-only build with these changes, and that's clean. Attempting a build with these issues fixed and a gcc7 shadow shows that these errors are gone (but there's a new set to investigate).
- 4
- 0
- 0
- 0
- 4
Description | From | Last Updated |
---|---|---|
i'm not sure it is correct, in some cases you should to check others definitions, but you are ignore it ... |
|
|
Does this comment silence gcc? I have memory that the default comment in this case should be / FALLTHROUGH / |
|
|
it is incorrect. variable is 'long' but you try to use ULONG_MAX - it has double size of variable max |
|
|
/ FALLTHROUGH / ? |
|
-
-
usr/src/uts/sun4/vm/vm_dep.h (Diff revision 1) it is incorrect.
variable is 'long' but you try to use ULONG_MAX - it has double size of variable max
-
-
usr/src/uts/sun4/os/trap.c (Diff revision 1) Does this comment silence gcc? I have memory that the default comment in this case should be / FALLTHROUGH /
-