Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Bugs: |
|
9729 kstat not exposing non-global zone stat counters
Review Request #1474 — Created Feb. 14, 2019 and submitted
Information | |
---|---|
cneira | |
illumos-gate | |
master | |
9729 | |
7e0e157... | |
Reviewers | |
general | |
This patch addresses : https://www.illumos.org/issues/9729
I took the changes done by Alasdair Lumsden to expose stat counters for the following modules :
icmp
ip
ip6
sctp
udp
cneira@Trixie:/build/illumos-omnios$ zoneadm list -icv
ID NAME STATUS PATH BRAND IP
0 global running / ipkg shared
1 t0 running /zcage/vms/t0 lx excl
- 9e19b8ed-ad9c-4284-a948-3cf803aaa3e0 configured /zcage/vms/9e19b8ed-ad9c-4284-a948-3cf803aaa3e0 lx excl
- 1fd17810-1517-47ad-8389-3557b74bdb11 configured /zcage/vms/1fd17810-1517-47ad-8389-3557b74bdb11 lx excl
- lxvm0 configured /zcage/vms/lxvm0 lx excl
- lxvm configured /zcage/vms/lxvm lx excl
- lxvm2 configured /zcage/vms/lxvm2 lx excl
- l1 configured /zcage/vms/l1 lx excl
cneira@Trixie:/build/illumos-omnios$ kstat -p ip::icmp:outMsgs
ip:0:icmp:outMsgs 0
ip:1:icmp:outMsgs 0
cneira@Trixie:/build/illumos-omnios$ kstat -p udp::udp:inDatagrams
udp:0:udp:inDatagrams 33
udp:1:udp:inDatagrams 0
cneira@Trixie:/build/illumos-omnios$ kstat -p tcp::tcp:inAckBytes
tcp:0:tcp:inAckBytes 321216
tcp:1:tcp:inAckBytes 0
omnios$ kstat -p sctp::sctp:sctpRtoMax
sctp:0:sctp:sctpRtoMax 60000
sctp:1:sctp:sctpRtoMax 60000
-
-
usr/src/uts/common/inet/ipf/solaris.c (Diff revision 1) Don't split the string like this, just move the entire string down to the next line and it should fit, otherwise something like:
cmn_err(CE_NOTE, "IP Filter: ipf_kstat_init(%p) " "installed %p, %p", ifs, ifs->ifs_kstatp[0], ifs->ifs_kstatp[1]);
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+136 -36) |
-
-
usr/src/uts/common/inet/ipf/solaris.c (Diff revision 2) You've lost a space in the message add one before the quote on the first line.
Change Summary:
fixed missing space
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+136 -36) |