10395 Add support for SMBIOS 3.2

Review Request #1470 — Created Feb. 11, 2019 and submitted

rm
illumos-gate
master
10395
42a31a0...
general

10395 Add support for SMBIOS 3.2
10396 Want libjedec
10397 Check for SMBIOS table with higher version
10398 smbios slot version check is broken for smbios 3.x
10399 smbios CPU Cache extended size not correctly calculated
10400 smbios(1M) slot printing could be clearer
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>

Test suites and regression testing, see 10395 testing notes.

  • 0
  • 0
  • 9
  • 4
  • 13
Description From Last Updated
seeemef@mac.com
  1. 
      
  2. usr/src/cmd/smbios/smbios.c (Diff revision 1)
     
     

    Should these read "Cache Size"?

  3. usr/src/cmd/smbios/smbios.c (Diff revision 1)
     
     

    Should these read "Logical Size"?

  4. usr/src/lib/libjedec/common/libjedec.c (Diff revision 1)
     
     

    "vaues" typo?

  5. usr/src/lib/libjedec/common/libjedec.c (Diff revision 1)
     
     

    space missing before parenthesis?

    1. There is no space in the official document.

  6. usr/src/lib/libjedec/common/libjedec.c (Diff revision 1)
     
     

    space missing?

    1. There is no space in the official document.

  7. usr/src/lib/libjedec/common/libjedec.c (Diff revision 1)
     
     

    "G.SKILL"?

    1. This is how it's presented in the official standard.

  8. usr/src/lib/libjedec/common/libjedec.c (Diff revision 1)
     
     

    "Compete!"?

    1. This is how it's presented in the official standard.

  9. Should this log slot.smbl_width?

  10. Should this be clarified as "data bus width (base)"?

  11. 
      
rm
seeemef@mac.com
  1. Two errors in a test string but otherwise LGTM

  2. missing space and typo

  3. 
      
rm
rm
rm
Review request changed

Status: Closed (submitted)

Loading...