10394 SPARC qemu panic in the fd module

Review Request #1468 — Created Feb. 11, 2019 and submitted

ptribble
illumos-gate
10394
general
Attempting to boot Tribblix for SPARC under qemu-system-sparc64, I see:

panic[cpu0]/thread=30001180760: BAD TRAP: type=31 rp=2a1002d2d70 addr=248 mmu_fsr=0 occurred in module "fd" due to a NULL pointer dereference

The fix here is at line 1272, only call fdmotoff if fdc->c_un has been initialized

Constructed an ISO with the fix, it now boots without the panic all the way to the installer prompt.

rm
  1. 
      
  2. usr/src/uts/sun/io/fd.c (Diff revision 1)
     
     
    This makes sense. I wonder though, if we should instead just be setting the value of unit after we've checked the timer. I guess it probably doesn't matter and this is fine. Thanks for putting this together.
  3. 
      
citrus
  1. Ship It!
  2. 
      
ptribble
Review request changed

Status: Closed (submitted)

Loading...