10390 consms: NULL pointer errors

Review Request #1464 - Created Feb. 11, 2019 and submitted

Information
Toomas Soome
illumos-gate
10390
e4e7215...
Reviewers
general
../../common/io/consms.c: In function 'consms_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/consms.c:277:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                     ^~~~
In file included from ../../common/io/consms.c:56:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
../../common/io/consms.c: In function 'consms_new_firm_event':
../../common/io/consms.c:976:13: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   fep->pair = NULL;
             ^
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Andrew Stormont
Andy Fiddaman
Toomas Soome
Andy Fiddaman
Gergő Mihály Doma
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...