10389 cn: NULL pointer errors

Review Request #1463 - Created Feb. 11, 2019 and submitted

Information
Toomas Soome
illumos-gate
10389
ba1fbb0...
Reviewers
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/cons.c:43:
../../common/io/cons.c: In function 'cn_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/cons.c:210:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                     ^~~~
In file included from ../../common/io/cons.c:68:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/cons.c:43:
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/cons.c:214:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                     ^~~~
In file included from ../../common/io/cons.c:68:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/cons.c:43:
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/cons.c:219:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                     ^~~~
In file included from ../../common/io/cons.c:68:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
Andy Fiddaman
Andrew Stormont
Gergő Mihály Doma
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...