10386 pbchk should catch capitalised "illumos" 10387 pbchk should check commit message spelling

Review Request #1461 — Created Feb. 11, 2019 and submitted

citrus
illumos-gate
master
10386, 10387
c1f5ef9...
general

10386 pbchk should catch capitalised "illumos"
10387 pbchk should check commit message spelling

% git show
commit f5484f02389d1413f9bb10665449ca45df018e73 (HEAD -> ig_Illumos)
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   Mon Feb 11 11:10:59 2019 +0000

    test (add noise to system.4 man page)

commit c1f5ef90a7d67939a1dc8966c165bfe02b4869e7
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   Mon Feb 11 11:08:45 2019 +0000

    10386 pbchk should catch capitalised "illumos"
    10387 pbchk should check commit message spelling
    1234 Make spellcheck test for Illumos and writeable ecstacy here

% git pbchk -p upstream_gate
Comments:
These comments are not valid bugs:
  test
These bug synopses don't match the database entries:
Synopsis of 1234 is wrong:
  should be: 'DNSSEC Validation plugin for Firefox'
         is: 'Make spellcheck test for Illumos and writeable ecstacy here'
Spellcheck:
comment line 4 - contains "ecstacy", a common misspelling of "ecstasy"
comment line 4 - contains "writeable"; please use "writable" instead for consistency with other documentation
comment line 4 - contains "Illumos"; please use "illumos" instead

Copyrights:
usr/src/man/man4/system.4: no copyright claim for current year found

Man page format/spelling:
usr/src/man/man4/system.4: Line 22 contains "ecstacy", a common misspelling of "ecstasy"
usr/src/man/man4/system.4: Line 22 contains "writeable"; please use "writable" instead for consistency with other documentation
usr/src/man/man4/system.4: Line 22 contains "Illumos"; please use "illumos" instead

white space nits:
usr/src/man/man4/system.4:291: space tab sequences
usr/src/man/man4/system.4:292: space tab sequences
usr/src/man/man4/system.4:293: space tab sequences

NB: Same with python3 =git-pbchk -p upstream_gate

citrus
tsoome
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...