10383 myri10ge: NULL pointer errors

Review Request #1458 - Created Feb. 11, 2019 and submitted

Information
Toomas Soome
illumos-gate
10383
6f82852...
Reviewers
general
../../common/io/myri10ge/drv/myri10ge.c: In function 'myri10ge_pull_jpool':
../../common/io/myri10ge/drv/myri10ge.c:416:13: error: comparison between pointer and integer [-Werror]
   if (*putp == NULL)
             ^~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/myri10ge/drv/myri10ge_var.h:36,
                 from ../../common/io/myri10ge/drv/myri10ge.c:38:
../../common/io/myri10ge/drv/myri10ge.c: In function 'myri10ge_pullup':
../../common/sys/null.h:32:14: error: passing argument 4 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/myri10ge/drv/myri10ge.c:2916:35: note: in expansion of macro 'NULL'
  mac_hcksum_set(mp, start, stuff, NULL, NULL, tx_offload_flags);
                                   ^~~~
In file included from ../../common/io/myri10ge/drv/myri10ge_var.h:47:0,
                 from ../../common/io/myri10ge/drv/myri10ge.c:38:
../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/myri10ge/drv/myri10ge_var.h:36,
                 from ../../common/io/myri10ge/drv/myri10ge.c:38:
../../common/sys/null.h:32:14: error: passing argument 5 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/myri10ge/drv/myri10ge.c:2916:41: note: in expansion of macro 'NULL'
  mac_hcksum_set(mp, start, stuff, NULL, NULL, tx_offload_flags);
                                         ^~~~
In file included from ../../common/io/myri10ge/drv/myri10ge_var.h:47:0,
                 from ../../common/io/myri10ge/drv/myri10ge.c:38:
../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Andrew Stormont
Andy Fiddaman
Toomas Soome
Toomas Soome
Andy Fiddaman
Toomas Soome
Andy Fiddaman
Gergő Mihály Doma
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...