10382 cxgbe: NULL pointer errors

Review Request #1457 - Created Feb. 11, 2019 and submitted

Information
Toomas Soome
illumos-gate
10382
0b3765f...
Reviewers
general
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/io/cxgbe/t4nex/t4_sge.c: In function 'get_frame_txinfo':
../../../common/sys/null.h:32:14: error: passing argument 2 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2491:21: note: in expansion of macro 'NULL'
   mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                     ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 3 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2491:27: note: in expansion of macro 'NULL'
   mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                           ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 4 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2491:33: note: in expansion of macro 'NULL'
   mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                                 ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 5 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2491:39: note: in expansion of macro 'NULL'
   mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                                       ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 2 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2522:23: note: in expansion of macro 'NULL'
     mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                       ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 3 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2522:29: note: in expansion of macro 'NULL'
     mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                             ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 4 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2522:35: note: in expansion of macro 'NULL'
     mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                                   ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
In file included from ../../../common/sys/param.h:48:0,
                 from ../../../common/sys/t_lock.h:38,
                 from ../../../common/sys/map.h:35,
                 from ../../../common/sys/ddi.h:37,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
../../../common/sys/null.h:32:14: error: passing argument 5 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../../common/io/cxgbe/t4nex/t4_sge.c:2522:41: note: in expansion of macro 'NULL'
     mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                                         ^~~~
In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                 from ../../../common/io/cxgbe/common/common.h:488,
                 from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
 extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
               ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
Andrew Stormont
Andy Fiddaman
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...