10371 vfs: cast between incompatible function types

Review Request #1446 — Created Feb. 11, 2019 and submitted

tsoome
illumos-gate
10371
6baeda6...
general
../../common/fs/vfs.c: In function 'fs_copyfsops':
../../common/fs/vfs.c:351:4: error: cast between incompatible function types from 'void (*)(vfs_t *)' {aka 'void (*)(struct vfs *)'} to 'int (*)()' [-Werror=cast-function-type]
    (fs_generic_func_p)fs_freevfs,
    ^
../../common/fs/vfs.c:352:4: error: cast between incompatible function types from 'void (*)(vfs_t *)' {aka 'void (*)(struct vfs *)'} to 'int (*)()' [-Werror=cast-function-type]
    (fs_generic_func_p)fs_freevfs, /* Shouldn't fail */
    ^
cc1: all warnings being treated as errors


  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
andy_js
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. Ship It!
  2. 
      
domag02
  1. Space followed-by tab nits.
  2. usr/src/uts/common/fs/vfs.c (Diff revision 1)
     
     
    Space followed by tab.
  3. usr/src/uts/common/fs/vfs.c (Diff revision 1)
     
     
    Space followed by tab.
  4. usr/src/uts/common/fs/vfs.c (Diff revision 1)
     
     
    Space followed by tab (+ in the next line).
  5. usr/src/uts/common/fs/vfs.c (Diff revision 1)
     
     
    Space followed by tab.
  6. usr/src/uts/common/fs/vfs.c (Diff revision 1)
     
     
    Space followed by tab.
  7. 
      
tsoome
andy_js
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...