10361 usr/lib - stop lint library generation and packaging

Review Request #1438 — Created Feb. 9, 2019 and submitted

citrus
illumos-gate
master
10361
69b4572...
general
10361 usr/lib - stop lint library generation and packaging

Build and onu (i386)

I've made changes to the top level usr/src/lib/Makefile.lib to prevent lint library generation and installation rather than update pretty much all ~2.3K makefiles under usr/src/lib. These can be cleaned up later or on an ongoing basis as components are touched.

I'm uploading this as two patch sets to make it easier to review:

  1. The changes to stop lint libraries and the packaging changes to go along with this;
  2. Removal of usr/src/lib/**/llib-l*

The second is large but is just deletion of these files.

You can also find these as the last two commits at https://github.com/citrus-it/illumos-omnios/commits/ig_llib_lib if you prefer.

citrus
jbk
  1. Ship It!
  2. 
      
ptribble
  1. I'm not entirely convinced that librsc is complete. It's been removed from packaging, but I can't see anywhere that stops us building it.

    (I think it's driven via scadm, and the librsc Makefile.com will need fixing. I can check this, but it'll take a few days before I can get to it.)

    1. Thanks for looking, I was intending to ask if you had time to test it on sparc :) - the build is clean on x86 as the removal of the LINTLIB etc. in usr/src/lib/Makefile.lib means that the targets end up as empty and aren't built.

    2. OK, so a build on sparc appears clean, there's no evidence of it using studio or creating any lint-related files, but packaging fails validation. The following errant symlinks end up in the proto area:
      
      usr/platform/SUNW,Sun-Fire-V440/lib/llib-lrsc.ln
      usr/platform/SUNW,Netra-T5220/lib/llib-lpcp.ln
      usr/platform/SUNW,Sun-Blade-T6320/lib/llib-lpcp.ln
      usr/platform/SUNW,Netra-CP3260/lib/llib-lpcp.ln
      usr/platform/SUNW,USBRDT-5240/lib/llib-lpcp.ln
      usr/platform/SUNW,SPARC-Enterprise-T5120/lib/llib-lpcp.ln
      usr/platform/SUNW,Netra-CP3060/lib/llib-lpcp.ln
      usr/platform/SUNW,Sun-Fire-T200/lib/llib-lpcp.ln
      usr/platform/SUNW,Sun-Blade-T6300/lib/llib-lpcp.ln
      usr/platform/SUNW,T5140/lib/llib-lpcp.ln
      usr/platform/SUNW,Sun-Fire-V250/lib/llib-lrsc.ln
      usr/platform/SUNW,Sun-Fire-V215/lib/llib-lrsc.ln
      usr/platform/SUNW,Sun-Fire-V445/lib/llib-lrsc.ln
      usr/platform/SUNW,Netra-T5440/lib/llib-lpcp.ln
      
      This, I think, means that the following changes are required:
      
      usr/src/lib/libpcp/Makefile.com
      - remove LINKED_LLIBLPCP_DIR
      - remove INS.slink8
      
      usr/src/lib/librsc/Makefile.com
      - remove LINKED_LLIBLRSC_DIR
      - remove INS.slink8
      - remove LINKED_LLIBLRSC_DIR from the install target
      - remove the rule for LINKED_LLIBLRSC_DIR
      
      (hope this makes sense)
  2. 
      
citrus
citrus
citrus
ptribble
  1. Ship It!
  2. 
      
jbk
  1. Ship It!
  2. 
      
storkone
  1. Looks ok. Juat add a missing copyright notice to /usr/src/pkg/manifests/service-fault-management.mf

  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...