10358 our console should support 256 colors

Review Request #1435 — Created Feb. 8, 2019 and submitted

tsoome
illumos-gate
10358
aa4005d...
general
10358 our console should support 256 colors


  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
tsoome
andy_js
  1. Ship It!
  2. 
      
citrus
  1. 
      
  2. usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 2)
     
     

    nit: space before ?

  3. usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 2)
     
     

    This doesn't do the right thing, for example -1 and 270 would not produce the error.

    if ((val < 0 || val > limit) || (val > 7 && val < 16)) ?

  4. usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 2)
     
     

    space before ?

  5. usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 2)
     
     

    Why no 7-16 check here?

  6. usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 2)
     
     

    ditto

  7. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...