6622 diverse NULL pointer constant issues in lib/

Review Request #142 — Created Feb. 6, 2016 and updated

risto3
illumos-gate
5218, 6622
5d00393...
general

6622 diverse NULL pointer constant issues in lib/



  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
rm
  1. 
      
  2. Is this trying to really compare against the character constant '\0' as pw is a char *?

  3. As this is a character pointer, shouldn't we be trying to compare against '\0' logically, even if we cast the type up to an int?

  4. As this is a character pointer, shouldn't we be trying to compare against '\0' logically, even if we cast the type up to an int?

  5. Can you fix the cstyle issue, where the == should be on the previous line while here?

  6. usr/src/lib/libgen/common/reg_compile.c (Diff revision 1)
     
     

    As this is a char *, shouldn't we be comparing against '\0'?

  7. I only made it through the first three pages, I'll try and come back and pick up the rest.

    However, the bug id here should be 6622.

    One other thing to consider is breaking this up into smaller changes so it'll be easier to wsdiff.

risto3
Review request changed

Change Summary:

correct issue reference to 6622
cstyled requested changes except for gss_mechs (too many to bother for the moment)

Summary:

-6621 diverse NULL pointer constant issues in lib/
+6622 diverse NULL pointer constant issues in lib/

Description:

~  

6621 diverse NULL pointer constant issues in lib/

  ~

6622 diverse NULL pointer constant issues in lib/

Bugs:

-6621
+6622

Commit:

-d9769e26ed3580a12a615fdac3ebf68a44bacee4
+5d00393dc2c7bf24549716ddacc08398e7dafb33

Diff:

Revision 2 (+953 -1055)

Show changes

Loading...