10317 iconv_modules is building with -I/usr/include

Review Request #1410 — Created Jan. 28, 2019 and submitted

tsoome
illumos-gate
10317
0e6c976...
general
10317 iconv_modules is building with -I/usr/include


  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
rm
  1. 
      
  2. usr/src/lib/iconv_modules/Makefile.iconv (Diff revision 1)
     
     
     
    I agree, that the fact that it's using CFLAGS instead of CPPFLAGS and so isn't ended up with the right search path is bad.
    
    However, we do still need to search -I$(ADJUNCT_PROTO)/usr/include as that's where we're going to find idnkit. On folks without an ADJUNCT_PROTO explicitly set, that's /usr/include. How are you finding idnkit without this part here?
    1. the -I$(ADJUNCT_PROTO)/usr/include is already where it is supposed to be - in usr/src/lib/iconv_modules/utf-8/Makefile.com, and this is why this patch does build without errors. Going to drop this issue.

    2. Yes, you're right. I missed that case. Thanks.

  3. 
      
rm
  1. Ship It!
  2. 
      
hans
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...