10293 - usr/cmd/sgs - remove lint and lint libraries

Review Request #1388 — Created Jan. 29, 2019 and submitted

Information
citrus
illumos-gate
master
10293
c8a0c13...
Reviewers
general 
10293 - usr/cmd/sgs - remove lint and lint libraries




 













 

 






 
 
 

  

   
  

  
    
   
  • 
    
    0
   
    • 
   
  • 
    
    0
   
    • 
   
  • 
    
    2
   
    • 
   
  • 
    
    1
   
    • 
   
  • 
    
    3
   
    • 
  

 

 

  

   
    

     Description
     From
     Last Updated
    

   
   


    


    


    

   
  

 












  

 








 














 





 

  

   




jlevon




   

   







  

 



 

  


   

   

    
 
jlevon


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Please remove cmd/sgs from $SRC/Makefile.lint - for tracking what's been de-linted, if for no other reason.
    

    I'm presuming that you intentionally didn't even think about tackling all the lint noise in the sources themselves ("LINTED").
    

    That I found a LINTFLAGS makes me think you could do with a "git grep" to find any remaining references? And maybe for .ln / llib?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Makefile.lint -> done
      

      No, I'm not tackling the #ifdef LINT and LINTED_xxx in the source as part of this change.
      

      Thanks, I've just been through and that was the only lint that I missed but there were some llib lines that I've now cleaned up too.
      
 
      

      2. 


 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      usr/src/cmd/sgs/librtld/Makefile.com
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Why MSGSRCS suddenly?
    

    (I didn't remark on any other instasnces of this I might find.)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      The chkmsg target used to run against LINTSRCS in these cases. I've renamed the variable and changed the chkmsg: targets to use the new name.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      usr/src/cmd/sgs/prof/Makefile.com
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    You left a LINTFLAGS here
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Why are we now defining MSGSRCS here?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   




citrus




   

   

  

 



 















 





 

  

   




jlevon




   

   







  

 



 

  


   

   

    
 
jlevon


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




tsoome




   

   







  

 



 

  


   

   

    
 
tsoome


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




richlowe




   

   







  

 



 

  


   

   

    
 
richlowe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Is there a reason you did SGS first?  I don't have any problem with it, I'm just worried I'm missing something.  (Maybe because the libraries we ship are early in the src/lib build?)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I actually started with usr/lib, trying to find a straightforward change I could make to the top-level Makefile to stop generation of all lint libraries. That mostly worked (although I'm not convinced it's the right approach) but it did not work for SGS and libc. So I chose SGS as a chunk to pick off first thinking it would be pretty small and enable any converations about how the wider lint removal should be done and its scope etc.
      

      It wasn't as small as I expected!
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




citrus




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...