Build error for dtrace_isa.c on sparc

Review Request #1374 — Created Jan. 16, 2019 and submitted

ptribble
illumos-gate
10254
general

Building on SPARC:

../../sparc/dtrace/dtrace_isa.c:945: error: conflicting types for 'dtrace_setreg'
../../common/sys/dtrace_impl.h:1265: note: previous declaration of 'dtrace_setreg' was here

In the intel version of the file, and the header, it's void(), while the sparc version incorrectly declares it to return int.

(And clearly, if it's void, it mustn't return a value.)

With the fix, sparc build no longer has the error.

andy_js
  1. 
      
  2. usr/src/uts/sparc/dtrace/dtrace_isa.c (Diff revision 1)
     
     
    You can drop the return entirely.
  3. 
      
ptribble
andy_js
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
wiedi
  1. Ship It!
  2. 
      
ptribble
Review request changed

Status: Closed (submitted)

Loading...