Build error for usr/src/uts/common/exec/elf/elf.c on sparc

Review Request #1372 — Created Jan. 16, 2019 and submitted

ptribble
illumos-gate
10245
general
On a SPARC build, we see the following error:

../../common/exec/elf/elf.c:841: error: unused variable 'fptype' [-Wunused-variable]
../../common/exec/elf/elf.c:840: error: unused variable 'fpsize' [-Wunused-variable]

The code that uses these variables is guarded for amd64, so the variables should be too.

With the fix, the sparc build no longer generates this error

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
citrus
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
igork
  1. 
      
  2. usr/src/uts/common/exec/elf/elf.c (Diff revision 1)
     
     

    will be more correct to use __x86 for all Intel platforms

    1. or to use:

      ifndef __sparc

      endif

    2. No, the critical thing is that the guard of the variables has to match the guard on the code. (And the guard on the code is correct as it's specific to the amd64 abi.)

  3. 
      
domag02
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
ptribble
Review request changed

Status: Closed (submitted)

Loading...