-
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 1) Is this trying to make sure if fits within a uint16_t, if so, use UINT16_MAX.
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 1) So, this will disable scaling, but what if it doesn't actually fit in the framebuffer? I'm not sure I see anything that deals with that case.
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 1) Why exactly do we only care about this now if the flag isn't set? Also, since the block is multiple lines (though only one statement) can we put parens around it?
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 1) Where does 16 come from in these expressions?
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 1) Please ensure that this is being built with c99 if you're going to do declarations here.
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+338 -120) |
-
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revisions 1 - 2) In the past you were doing >= 1 << 16, so shouldn't this be '> UINT16_MAX'?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+373 -120) |
-
Format string signedness mismatch.
-
usr/src/boot/sys/boot/common/gfx_fb.c (Diff revision 3) This line should be:
printf("Image %ux%u -> %ux%u @%ux%u\n",
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+373 -120) |
Change Summary:
minor comment clarification.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+373 -120) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+385 -120) |
-
I'm not sure about that this is a real issue, but now every value accepted between in range of
n * UINT32_MAX + 0
andn * UINT32_MAX + gfx_fb.framebuffer_common.framebuffer_height
(similar rules applies tox2
,y1
,x1
andf
variables, too) when this code compiled on LP64 datamodel.Drop this issue if you think it's not important.
-
usr/src/common/ficl/loader.c (Diff revision 6) When the used datamodel is LP64, implicit type conversion can happen (variables gets only the lower 32bit of the original values).
ficlStackPopUnsigned()
return type isficlUnsigned
, wich is typedef-ed asuint32_t
oruint64_t
on LP64 (see in /usr/src/common/ficl/ficlplatform/unix.h, line 58).