6617 NULL pointer constant issues in ucbcmd

Review Request #137 — Created Feb. 6, 2016 and updated

risto3
illumos-gate
5218, 6617, 6625
3c9b37e...
general

6617 NULL pointer constant issues in ucbcmd
6625 cleanup warnings in usr/src/ucbcmd/chown



  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
risto3
rm
  1. 
      
  2. usr/src/ucbcmd/chown/Makefile (Diff revision 1)
     
     

    Please make sure a second bug is opened to deal with warning clean up.

  3. usr/src/ucbcmd/chown/chown.c (Diff revision 1)
     
     

    Shouldn't this be compared against '\0'.

  4. usr/src/ucbcmd/mkstr/Makefile (Diff revision 1)
     
     

    If this is no longer necessary, delete, don't comment it out.

  5. 
      
risto3
risto3
rm
  1. 
      
  2. usr/src/ucbcmd/chown/chown.c (Diff revisions 1 - 2)
     
     
    Erm, now this is missing the comparison to anything at all. It should be explicit, eg.:
    
    while ((c = *s++) != '\0')
    1. In comparison to the initial file from master, literally only the missing parenthesis
      from CERRWARN is fixed... cstyle doesn't balk for me here. Still add == '\0' ?

  3. 
      
risto3
Review request changed

Change Summary:

comparison made explicit as requested

Commit:

-6df01e9e51cb1ca3793912a27a0cbc73ecba7e1c
+3c9b37ef4fb40c3c1b7e9069f0f6d8923d41332a

Diff:

Revision 3 (+34 -34)

Show changes

Loading...