6615 diverse NULL pointer constant issues in uts/common

Review Request #135 - Created Feb. 6, 2016 and updated

Information
Richard PALO
illumos-gate
5218, 6615
4c00d33...
Reviewers
general
6615 diverse NULL pointer constant issues in uts/common

pre wsdiff is gate at commit bc07d1f with enable_perl64 patch applied

git pbchk: cleaned for cstyle, ignored copyright messages
there's some usr/src/uts/common/gssapi/include/mechglueP.h: 189: unary * followed by space
sort of messages... I'll file some issues on cstyle in https://www.illumos.org/projects/illumos-gate
also, the nesting was hideous in a couple of files, YOURDON would have been horrified.

richard@omnis:/home/richard/src/illumos-gate$ git whatchanged -1
commit a9e95f03bad60959cfe757ba1407734771275e40
Author: Richard PALO <richard@NetBSD.org>
Date:   Sat Feb 6 16:12:10 2016 +0100

    6615 diverse NULL pointer constant issues in uts/common/

:100644 100644 3627ed6... 8fdb620... M  usr/src/uts/common/avs/ncall/ncall.c
:100644 100644 098990b... ece952c... M  usr/src/uts/common/avs/ns/dsw/dsw_dev.c
:100644 100644 28750c6... b59a2ab... M  usr/src/uts/common/avs/ns/rdc/rdc.c
:100644 100644 5656cd5... b3f4ffd... M  usr/src/uts/common/avs/ns/sdbc/sd_bcache.c
:100644 100644 e63bf9d... 1935ea0... M  usr/src/uts/common/avs/ns/sdbc/sd_misc.c
:100644 100644 171ac3e... fd58860... M  usr/src/uts/common/avs/ns/solaris/nsc_raw.c
:100644 100644 8ea464c... 2ce273e... M  usr/src/uts/common/avs/ns/sv/sv.c
:100644 100644 7ee4a93... f33015e... M  usr/src/uts/common/avs/ns/unistat/spcs_s_k.c
:100644 100644 ed2744d... a85cb6a... M  usr/src/uts/common/c2/audit.c
:100644 100644 3ca2c75... 0e52e76... M  usr/src/uts/common/c2/audit_event.c
:100644 100644 54624e7... 8a82aa5... M  usr/src/uts/common/c2/audit_io.c
:100644 100644 f82bd21... 196ae51... M  usr/src/uts/common/c2/audit_start.c
:100644 100644 caca9ea... 829eb99... M  usr/src/uts/common/cpr/cpr_stat.c
:100644 100644 7d6f726... 5fd2c98... M  usr/src/uts/common/crypto/api/kcf_dual.c
:100644 100644 518b0bc... c2cbf6b... M  usr/src/uts/common/crypto/core/kcf_cryptoadm.c
:100644 100644 6a30f0b... 09c481f... M  usr/src/uts/common/crypto/io/aes.c
:100644 100644 81fe549... ad3c9f0... M  usr/src/uts/common/crypto/io/arcfour.c
:100644 100644 6c53ae2... a217dd4... M  usr/src/uts/common/crypto/io/blowfish.c
:100644 100644 b76cbae... 9df70d1... M  usr/src/uts/common/crypto/io/dca.c
:100644 100644 6259c83... 1006512... M  usr/src/uts/common/crypto/io/dprov.c
:100644 100644 40c8784... 1f34b66... M  usr/src/uts/common/crypto/io/ecc.c
:100644 100644 b574a0d... 86722e0... M  usr/src/uts/common/crypto/io/md4_mod.c
:100644 100644 7c7759d... 13c0790... M  usr/src/uts/common/crypto/io/md5_mod.c
:100644 100644 3542051... 6089ddf... M  usr/src/uts/common/crypto/io/rsa.c
:100644 100644 5765244... cfccd86... M  usr/src/uts/common/crypto/io/sha1_mod.c
:100644 100644 301a97c... 23c73d1... M  usr/src/uts/common/crypto/io/sha2_mod.c
:100644 100644 dec74a9... c5e5942... M  usr/src/uts/common/crypto/io/swrand.c
:100644 100644 f4f43a6... 10723a0... M  usr/src/uts/common/des/des_crypt.c
:100644 100644 46fbf71... 55dd161... M  usr/src/uts/common/disp/class.c
:100644 100644 ab5ba27... 9a37e03... M  usr/src/uts/common/disp/fx.c
:100644 100644 8fd96cc... 9da8175... M  usr/src/uts/common/dtrace/dcpc.c
:100644 100644 3aeeef2... f96ce5e... M  usr/src/uts/common/dtrace/dtrace.c
:100644 100644 3948dd2... 7546c36... M  usr/src/uts/common/dtrace/fasttrap.c
:100644 100644 106fb73... eff8aac... M  usr/src/uts/common/dtrace/profile.c
:100644 100644 3d36ce9... 5f50891... M  usr/src/uts/common/dtrace/systrace.c
:100644 100644 dc04b29... 4f539d2... M  usr/src/uts/common/exec/elf/elf.c
:100644 100644 c934752... 950d373... M  usr/src/uts/common/gssapi/gssd_clnt_stubs.c
:100644 100644 f79b660... 8fb05b8... M  usr/src/uts/common/gssapi/include/mechglueP.h
:100644 100644 43c42bd... 0161ee7... M  usr/src/uts/common/gssapi/mechs/krb5/crypto/cksumtypes.c
:100644 100644 7566a0e... 4c52848... M  usr/src/uts/common/gssapi/mechs/krb5/crypto/etypes.c
:100644 100644 544e180... 2c56f77... M  usr/src/uts/common/inet/ip/inet_ntop.c
:100644 100644 f006e83... 62f1680... M  usr/src/uts/common/inet/ip/ip.c
:100644 100644 c0b184e... 82ac13e... M  usr/src/uts/common/inet/ip/ip6.c
:100644 100644 62ccd43... c7a38db... M  usr/src/uts/common/inet/ip/ip6_ire.c
:100644 100644 85ee142... f325f01... M  usr/src/uts/common/inet/ip/ip_attr.c
:100644 100644 533713e... f44c91f... M  usr/src/uts/common/inet/ip/ip_ire.c
:100644 100644 c7532aa... 2826a04... M  usr/src/uts/common/inet/ip/ip_netinfo.c
:100644 100644 cb24250... 0f12439... M  usr/src/uts/common/inet/ip/sadb.c
:100644 100644 5029a5b... 6b95495... M  usr/src/uts/common/inet/ipd/ipd.c
:100644 100644 9110c95... 8311794... M  usr/src/uts/common/inet/kssl/ksslapi.c
:100644 100644 5476656... b238fec... M  usr/src/uts/common/inet/kssl/ksslfilter.c
:100644 100644 f6de3fb... d618bb6... M  usr/src/uts/common/inet/kssl/ksslrec.c
:100644 100644 adc28ae... b5f1187... M  usr/src/uts/common/inet/sctp/sctp.c
:100644 100644 851a0ec... 75e880d... M  usr/src/uts/common/ipp/ippconf.c
:100644 100644 0f6ee79... eeaf204... M  usr/src/uts/common/kiconv/kiconv_ja/kiconv_ja.c
:100644 100644 90303d4... 5f58b11... M  usr/src/uts/common/krtld/kobj.c
:100644 100644 6ed1fff... 6709de6... M  usr/src/uts/common/pcmcia/cis/cis.c
:100644 100644 8f37d2a... f3d338f... M  usr/src/uts/common/pcmcia/cis/cis_handlers.c
:100644 100644 ae0a898... ae7a2b8... M  usr/src/uts/common/pcmcia/cs/cs.c
:100644 100644 3b08cbc... e97c443... M  usr/src/uts/common/pcmcia/nexus/pcmcia.c
:100644 100644 cb64eac... bff8e9a... M  usr/src/uts/common/pcmcia/sys/cis.h
:100644 100644 beab2b6... 2eddffe... M  usr/src/uts/common/rpc/clnt_clts.c
:100644 100644 22df0f0... 78f9541... M  usr/src/uts/common/rpc/rdma_subr.c
:100644 100644 ceb153c... c4964d4... M  usr/src/uts/common/rpc/rpc_subr.c
:100644 100644 07719f7... 086ae47... M  usr/src/uts/common/rpc/rpcib.c
:100644 100644 e0a0fe3... d15b8db... M  usr/src/uts/common/rpc/svc_rdma.c
:100644 100644 a76a927... 035eea8... M  usr/src/uts/common/sys/dld_impl.h
:100644 100644 6695d0f... 752d09d... M  usr/src/uts/common/sys/fibre-channel/fca/qlc/ql_api.h
:100644 100644 2d5e57d... 948ab45... M  usr/src/uts/common/sys/fibre-channel/fca/qlc/ql_mbx.h
:100644 100644 7be80c4... be3a0ff... M  usr/src/uts/common/sys/pcie_impl.h
:100644 100644 89b6b1d... 256a68a... M  usr/src/uts/common/sys/pciev.h
:100644 100644 3428035... f552598... M  usr/src/uts/common/sys/sata/sata_blacklist.h
:100644 100644 be60d1a... efb1620... M  usr/src/uts/common/syscall/lgrpsys.c
:100644 100644 53ecd8c... 361654c... M  usr/src/uts/common/syscall/lwp_create.c
:100644 100644 cc125f1... 2c6eb32... M  usr/src/uts/common/syscall/poll.c
:100644 100644 645f005... bf87d97... M  usr/src/uts/common/syscall/pset.c
:100644 100644 2dda400... b0f8873... M  usr/src/uts/common/syscall/uadmin.c
:100644 100644 f814066... 50c8838... M  usr/src/uts/common/tnf/tnf.c
:100644 100644 ad15bec... 31a85d4... M  usr/src/uts/common/vm/hat_refmod.c
:100644 100644 d33ff00... 02c844b... M  usr/src/uts/common/vm/seg_kp.c
:100644 100644 4955875... 1bd0c92... M  usr/src/uts/common/xen/io/evtchn_dev.c
:100644 100644 a739f5b... 4a4ef5a... M  usr/src/uts/common/xen/io/xdb.c
:100644 100644 b0cb441... 9a6fcb6... M  usr/src/uts/common/xen/io/xenbus_client.c
:100644 100644 56c1308... b23c7fa... M  usr/src/uts/common/xen/io/xenbus_dev.c
:100644 100644 aa80442... 8b97760... M  usr/src/uts/common/xen/io/xencons.c
:100644 100644 9a51328... 0c9d999... M  usr/src/uts/common/xen/io/xnbo.c
:100644 100644 85dd5d7... bdd0963... M  usr/src/uts/common/xen/os/xvdi.c

wsdiff attached with is now common for il_6609 .. il_6615

ignoring all but 'ELF .text'

richard@omnis:/home/richard/src/illumos-gate$ ggrep -B1 'NOTE: ELF .text' /tmp/wsdiff.log |grep -Ev 'NOTE:|--'
usr/kernel/drv/amd64/ii
usr/lib/amd64/libzpool.so.1
usr/lib/libzpool.so.1
platform/i86pc/kernel/drv/amd64/dr
kernel/misc/amd64/kgssapi
kernel/misc/amd64/dls
kernel/misc/dls
kernel/drv/amd64/softmac
kernel/drv/amd64/qlge
kernel/drv/amd64/llc1
kernel/drv/amd64/zfs
kernel/drv/amd64/mpt_sas
kernel/drv/amd64/dtrace
kernel/drv/softmac
kernel/drv/mpt_sas
kernel/drv/dtrace
kernel/drv/zfs
kernel/fs/amd64/zfs
kernel/fs/zfs
kernel/genunix

all are seemingly equivalent but with line additions/suppressions (cstyle, ctf?) with the exception of the following x86_64 which seem equivalent as well, but the x86_64 codegeneration, in particular for NOPs, is slightly different, and in most cases more compact:

usr/kernel/drv/amd64/ii
kernel/misc/amd64/kgssapi
kernel/drv/amd64/qlge
kernel/drv/amd64/llc1

I'm running this now (since rebasing with the enable_perl64).

BTW, the collective patchset is also available via https://github.com/risto3/illumos-gate/commits/il_uts-NULL (for the uts/ part of il_5218, that is: il_6609 .. il_6615)

Files


Richard PALO
Richard PALO
Richard PALO
Review request changed

Change Summary:

updates to kcf_crytoadm.c, mechglueP.h and cs.c based upon comments from jeffpc@

Commit:

-a9e95f03bad60959cfe757ba1407734771275e40
+4c00d33253674c3b80977d1049ce5cddd004196a

Diff:

Revision 4 (+4045 -4039)

Show changes

Loading...