10186 uts: font functions should check if the char is from the input domain

Review Request #1347 — Created Jan. 8, 2019 and submitted

tsoome
illumos-gate
10186
ea31e11...
general
10186 uts: font functions should check if the char is from the input domain


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
rm
  1. 
      
  2. usr/src/uts/common/font/font.c (Diff revision 2)
     
     
    General question on all of these. Is the idea here that we're going to get a code point as the argument in c? I just ask as ENCODED_CHARS is 256, which to me suggests it's probably not a UTF-8 value, but an ISO-8859-* kind of thing. I guess the fonts we care about for the kernel right now aren't utf-8 aware anyways, so it's probably a non-issue, but just wanted to check my understanding.
    1. Yes. The tem will get UTF-8 byte stream which we assemble to unicode wide char (8859-1 right now) and which is passed down for rendering either on bitmap or vga text console. The current fonts in kernel are indeed only 8859-1 fonts and what we want to happen is to get our rendering part to be set up to be prepared to receive the wide chars. This update does address the bitmap part, the VGA text must wait still, till we have gfx_private...

      Eventually we will switch font rendering to use usr/src/common/font/font.c which is already waiting. Also the loader FB implementation is using the same concept, implementing both bitmap and vga text components.

      Of course in final font.c we do not operate on array directly, since the glyph space is not contiguous, but if the glyph is not found, we will use special "default" char.

  3. 
      
rm
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...