-
-
usr/src/cmd/dd/dd.c (Diff revision 1) LGTM, only small nitpicks to be consistent with the style:
- put a space before obytes
- remove space between sizeof and the following bracket
-
Ship It!
-
usr/src/cmd/dd/dd.c (Diff revision 1) You added missing spaces around & in other cases, so please add it here too.
-
usr/src/cmd/dd/dd.c (Diff revision 1) You added missing spaces around & in other cases, so please add it here too.
-
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+199 -351) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+226 -379) |
-
-
usr/src/cmd/dd/dd.c (Diff revisions 1 - 2) Please, remove the blank before the opening square bracket.
-
-
-
usr/src/cmd/dd/dd.c (Diff revision 3) Pointless to use
BIG
here (as a limiting number), if the returned value is casted to unsigned int.#include <limits.h> . . . ... = (unsigned)number(UINT_MAX);
-
-
-
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+234 -387) |