10177 etdump: additional cstyle cleanup and remove unused functions

Review Request #1341 — Created Jan. 5, 2019 and submitted

tsoome
illumos-gate
10177
dd3d442...
general
10177 etdump: additional cstyle cleanup and remove unused functions

tsoome@beastie:/code/illumos-gate/usr/src/cmd/etdump$ ./etdump -f shell /rpool/dc/media/OpenIndiana_Text_X86.iso
et_platform=default;et_system=i386;et_lba=166;et_sectors=4
et_platform=efi;et_system=i386;et_lba=167;et_sectors=8800
tsoome@beastie:/code/illumos-gate/usr/src/cmd/etdump$ ./etdump -f text /rpool/dc/media/OpenIndiana_Text_X86.iso
Image in /rpool/dc/media/OpenIndiana_Text_X86.iso
Default entry
System i386
Start LBA 166(0xa6), sector count 4(0x4)
Media type: no emulation

Section header: efi, final
Section entry
System i386
Start LBA 167(0xa7), sector count 8800(0x2260)
Media type: no emulation
tsoome@beastie:/code/illumos-gate/usr/src/cmd/etdump$

tsoome
jlevon
  1. Ship It!
  2. 
      
domag02
  1. LGTM.

    It was part of the original intent to remove the blanks before the hexadecimal representations?

     Default entry
             System i386
    -        Start LBA 166 (0xa6), sector count 4 (0x4)
    +        Start LBA 166(0xa6), sector count 4(0x4)
             Media type: no emulation
    
     Section header: efi, final
             Section entry
                     System i386
    -                Start LBA 167 (0xa7), sector count 8800 (0x2260)
    +                Start LBA 167(0xa7), sector count 8800(0x2260)
                     Media type: no emulation
    
  2. 
      
tsoome
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...