10166 loader: support com.delphix:removing

Review Request #1336 — Created Dec. 26, 2018 and submitted

tsoome
illumos-gate
10166
e02c92f...
general
10166 loader: support com.delphix:removing

Verified we can read the pool with removal enabled and in progress.

  • 0
  • 0
  • 4
  • 1
  • 5
Description From Last Updated
domag02
  1. id variable type is uint64_t, so please use the corresponding format macro constant from <inttypes.h>.

  2. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)
     
     

    This line should be:

    asprintf(&name, "%s%d-%" PRIu64, type,
    
  3. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)
     
     

    asprintf(&name, "%s-%" PRIu64, type, id);
    
  4. 
      
tsoome
mahrens
  1. 
      
  2. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 2)
     
     
     
     
     

    That's not a good assumption to make in general (it could be GB's in some cases). It looks like you've handled the malloc() error below; is there any way to provide a more specific error message to the user?

    1. Yep, I did add printf to notify the user. And yes, I did read the comment about size - unfortunately we can not really handle gigabytes during the boot.

  3. 
      
tsoome
tsoome
jjelinek
  1. This looks good to me, I just saw a couple of small things.

  2. usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 4)
     
     

    This sentence is incomplete. Should it say "We don't do this for...", or should it say something else?

    1. Actually it is literal copy from vdev_indirect.c. This sentence is complementing previous one, I do agree it feels badly worded, but I'm not sure what is the best way there. Fix should land on both instances:)

  3. usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 4)
     
     

    Should this code check the io_error that can be set in vdev_indirect_gather_splits?

  4. 
      
tsoome
jjelinek
  1. Ship It!
  2. 
      
tsoome
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...