10165 libzpool: passing argument 1 to restrict-qualified parameter aliases with argument 4

Review Request #1335 — Created Dec. 25, 2018 and submitted Jan. 17, 2019, 8:52 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	10165
Depends On:
Commit:	2e55908...
Reviewers
Groups:	general
People:

Description

../../../uts/common/fs/zfs/dsl_dataset.c: In function 'dsl_get_mountpoint':
../../../uts/common/fs/zfs/dsl_dataset.c:2186:3: error: passing argument 1 to re
strict-qualified parameter aliases with argument 4 [-Werror=restrict]
   (void) snprintf(value, ZAP_MAXVALUELEN, "%s", value);
   ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
If you remove else, them please update this comment line. See here: ZFS on Linux, /module/zfs/dsl_dataset.c: line 2381	domag02	Dec. 26, 2018, 10:02 a.m.
It would be better to remove the whole else arm, see here: ZFS on Linux, /module/zfs/dsl_dataset.c: line 2433	domag02	Dec. 26, 2018, 10:02 a.m.

A better solution from ZFS on Linux.
Commit:
OpenZFS 7431 - ZFS Channel Programs

usr/src/uts/common/fs/zfs/dsl_dataset.c (Diff revision 1)

Show all issues

If you remove else, them please update this comment line.
See here: ZFS on Linux, /module/zfs/dsl_dataset.c: line 2381

usr/src/uts/common/fs/zfs/dsl_dataset.c (Diff revision 1)

Show all issues

It would be better to remove the whole else arm, see here:
ZFS on Linux, /module/zfs/dsl_dataset.c: line 2433

usr/src/uts/common/fs/zfs/dsl_dataset.c (Diff revision 1)

value[ZAP_MAXVALUELEN - 1] = '\0' ?

tsoome Dec. 26, 2018, 10:15 a.m.

As pointed above, it seems we really do not need this construct here at all.

Commit:

-	77b9c70e132d2945a8bb79e367b740dae470ea9b
+	2e5590838444068dfd9caec3619bc805dd3e7920

Diff:

Revision 2 (+5 -4)

Show changes

usr/src/uts/common/fs/zfs/dsl_dataset.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

10165 libzpool: passing argument 1 to restrict-qualified parameter aliases with argument 4

Commit:

Diff:

Status: Closed (submitted)