Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.
Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.
Review Request #1334 — Created Dec. 25, 2018 and submitted Dec. 29, 2018, 2:49 p.m.
../common/inspect.c:101:27: error: passing argument 2 to restrict-qualified para meter aliases with argument 1 [-Werror=restrict] (void) realpath(_alter, _alter); ~~~~~~ ^~~~~~ cc1: all warnings being treated as errors
Buffer overrun can happen.
Not for this issue: Notify the user if the path is too long (and turncation happened).
C-style.
"If one arm of an if-else statement contains braces, all arms should contain braces."
Same.
Revision 2 (+10 -7)
Show changes
Ship It!
domag02
