10164 crle: passing argument 2 to restrict-qualified parameter aliases with argument 1

Review Request #1334 — Created Dec. 25, 2018 and submitted

tsoome
illumos-gate
10164
d1e78e9...
general
../common/inspect.c:101:27: error: passing argument 2 to restrict-qualified para
meter aliases with argument 1 [-Werror=restrict]
   (void) realpath(_alter, _alter);
                   ~~~~~~  ^~~~~~
cc1: all warnings being treated as errors


  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
domag02
  1. 
      
  2. usr/src/cmd/sgs/crle/common/inspect.c (Diff revision 1)
     
     
    Buffer overrun can happen.
    1. Not for this issue:
      Notify the user if the path is too long (and turncation happened).

  3. 
      
domag02
  1. C-style.
  2. usr/src/cmd/sgs/crle/common/inspect.c (Diff revision 1)
     
     
    "If one arm of an if-else statement contains braces, all arms should contain braces."
  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...