-
-
-
usr/src/cmd/fs.d/ufs/fsck/pass2.c (Diff revision 1) Whitespace followed by tab (+ in the next 6 lines).
-
usr/src/cmd/fs.d/ufs/fsck/pass2.c (Diff revision 1) "If one arm of an if-else statement contains braces, all arms should contain braces."
10163 ufs_fsck: bitwise comparison always evaluates to false
Review Request #1333 — Created Dec. 25, 2018 and submitted
Information | |
---|---|
tsoome | |
illumos-gate | |
10163 | |
7214b03... | |
Reviewers | |
general | |
pass2.c: In function 'pass2': pass2.c:243:42: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] if ((statemap[inp->i_number] & STMASK) == DCLEAR || ^~ cc1: all warnings being treated as errors
Change Summary:
cstyle cleanup
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+35 -34) |
-
-
usr/src/cmd/fs.d/ufs/fsck/pass2.c (Diff revision 2) How did you decide to also check for INCLEAR here as opposed to changing the right hand side to only be DSTATE?